Merged
Conversation
Unless more changes are made to cgmath before 0.18 is released, this should make this library compatible with that version.
This updates all dependencies except for `approx` and `genmesh`, which would require more work to update. Fixes rustgd#117.
Contributor
Author
|
Just noticed #118, sorry for the duplicate work. This one also updates the benchmarks though, so they should compile without issues. A follow-up will still be needed to update |
Collaborator
|
CI seems to be dead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates all dependencies except for
approx(which is updated to 0.4 but not 0.5) andgenmesh, which would require more work to update.Fixes #117, and makes this library compatible with cgmath 0.18.
This change is